This does lose a bit of context, but not much. Methods still have their signatures visible and variables are... well... variables.
The idea is, if a client wants to later do filtering and sorting of symbols, we should not be doing that on the whole line, which might be left padded with tabs and have other punctuation. We already had a report that this does not work well. It almost works if a client strip()s the description before using it at all.
LSP completer instead uses extra_data to supply identifier name and kind, but omnisharp-roslyn does not provide us with a symbol kind and thus we can only put ref[ 'Text' ] in the description.
@teasp00n was the user who pointed out the problems with using the whole line for filtering.
mergify[bot]
commented
8 months ago
This does lose a bit of context, but not much. Methods still have their signatures visible and variables are... well... variables.
The idea is, if a client wants to later do filtering and sorting of symbols, we should not be doing that on the whole line, which might be left padded with tabs and have other punctuation. We already had a report that this does not work well. It almost works if a client
strip()s the description before using it at all.LSP completer instead uses
extra_datato supply identifier name and kind, but omnisharp-roslyn does not provide us with a symbol kind and thus we can only putref[ 'Text' ]in the description.@teasp00n was the user who pointed out the problems with using the whole line for filtering.
This change is