Closed bstaletic closed 6 months ago
Merging #1728 (5fb0927) into master (0ce532e) will increase coverage by
0.40%
. The diff coverage is66.66%
.
According to the coverage data, we're only ever dealing with errors in our tests, at least for C# and TS.
Don't we just need some code which produces a warning and error on the same line.
I think clangd does this. maybe something like:
int x;
if ( x = 2 )
{
}
With -Wno-error -Werror=uninitialized
Thanks for sending a PR!
Users are more likely to be interested in errors than warnings in /detailed_diagnostic responses. That means we need to sort the diagnostics before finding the one nearest to the cursor.
For LSP completers, that's easy as the severity is numerical. For Omnisharp-roslyn and TSServer, the severity is a word and we can't just say
sort( key = severity )
.Since LSP severity was convenient for comparison, I have opted for sorting C# and TS diags by the equivalent LSP severity.
This change is![Reviewable](https://reviewable.io/review_button.svg)