ycm-core / ycmd

A code-completion & code-comprehension server
https://ycm-core.github.io/ycmd/
GNU General Public License v3.0
1.69k stars 764 forks source link

[READY] Use the archive with precompiled binaries for updating the resource dir #1741

Closed bstaletic closed 4 months ago

bstaletic commented 5 months ago

While most headers in the resource directory are present in the clang source archive, some are generated during compiling.

As a bonus, non-header files do not exist in the resource directory, in the archives containing binaries. Previously we have manually removed a CMakeLists.txt, but have been leaving behind some READMEs.

HLSL headers are not installed, because the feature is highly experimental. openmp_wrappers/{stdlib.h,time.h} are not intended to be included in resource directory.

Closes #1740


This change is Reviewable

codecov[bot] commented 5 months ago

Codecov Report

Merging #1741 (60d43a5) into master (da9c643) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1741 +/- ## ======================================= Coverage 95.85% 95.85% ======================================= Files 84 84 Lines 8318 8318 Branches 163 163 ======================================= Hits 7973 7973 Misses 295 295 Partials 50 50 ```
bstaletic commented 5 months ago

Seems to be working!

puremourning commented 4 months ago
:lgtm:
mergify[bot] commented 4 months ago

Thanks for sending a PR!