Pin go version to avoid gopls issues

ycm-core / ycmd

A code-completion & code-comprehension server

https://ycm-core.github.io/ycmd/

GNU General Public License v3.0

1.69k stars 764 forks source link

Pin go version to avoid gopls issues #1756

Closed puremourning closed 3 weeks ago

puremourning commented 3 weeks ago

This change is

latest stable go 1.23 is incompatible with our gopls version
we can't just upgrade gopls because the new gopls includes code action command that use showDocument requests which are not supported by YCM, and gopls ignores the client capability

So to make CI green we pin the go version. Unfortunately this is temporary as users will eventually start using new go and having gopls problems.

puremourning commented 3 weeks ago

Related gopls bug: https://github.com/golang/go/issues/68904

bstaletic commented 3 weeks ago

Just one other suggestion, since currently some users will run into the problem with the new go. How about we add @ExpectedFailure to the two FixIt tests?

puremourning commented 3 weeks ago

Actually that's a good idea. We can just reference the bug.

bstaletic commented 3 weeks ago

We can close this one. Still, thanks for trying to fix it.