ycm-core / ycmd

A code-completion & code-comprehension server
https://ycm-core.github.io/ycmd/
GNU General Public License v3.0
1.69k stars 764 forks source link

[READY] Add support for DocumentSymbol in document outline requests #1757

Closed bstaletic closed 3 weeks ago

bstaletic commented 3 weeks ago

I'm not too happy about this. Omnisharp LSP assumes clients support this. We could, but it comes at the cost of manually flattening the hierarchy. That's what this pull request does.

Alternatives include:

EDIT: Switched to the first alternative, as discussed in gitter.


This change is Reviewable

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.92%. Comparing base (1026c83) to head (3027d22). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1757 +/- ## ========================================== + Coverage 95.90% 95.92% +0.01% ========================================== Files 84 84 Lines 8450 8462 +12 Branches 163 163 ========================================== + Hits 8104 8117 +13 + Misses 296 295 -1 Partials 50 50 ```
bstaletic commented 3 weeks ago

I'll merge this, to progress the C# stuff.