search

ycphs / openxlsx

openxlsx - a fast way to read and write complex xslx files
https://ycphs.github.io/openxlsx/
Other
226 stars 75 forks source link

To avoid "Specified part does not exist in the package" error when op… #286

Closed acobolew closed 3 years ago

acobolew commented 3 years ago

Fixes #285

JanMarvin commented 3 years ago

Hi @acobolew , thanks for the issue and the pull request. Your proposal is kind of a hack, the "better" solution would be to fix the content creation file and only include the drawing folder if it's required. Though that might create a lot more headaches, therefore I'd merge this pull request 👍 PD: Iirc there is some other open issue regarding the issue, I'll see if I can find it.

JanMarvin commented 3 years ago

This is fix 1 from https://github.com/ycphs/openxlsx/issues/231#issuecomment-907809082

codecov-commenter commented 3 years ago

Codecov Report

Merging #286 (62b5191) into master (4e45e8c) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   66.48%   66.49%   +0.01%     
==========================================
  Files          34       34              
  Lines        8939     8942       +3     
==========================================
+ Hits         5943     5946       +3     
  Misses       2996     2996
Impacted Files Coverage Δ
R/WorkbookClass.R 59.14% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8bbdd0...62b5191. Read the comment docs.

JanMarvin commented 3 years ago

If you want to, please add a sentence to the news file, otherwise looking good!