search

ycphs / openxlsx

openxlsx - a fast way to read and write complex xslx files
https://ycphs.github.io/openxlsx/
Other
220 stars 74 forks source link

Preserve window size and position, also get and set #383

Closed michael-dewar closed 4 months ago

michael-dewar commented 1 year ago

This PR will preserve the size and position of the window when you open the xlsx in Excel. There are also functions to set and get directly.

codecov-commenter commented 1 year ago

Codecov Report

Merging #383 (3f91f18) into master (e7b699e) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   67.76%   67.90%   +0.14%     
==========================================
  Files          34       35       +1     
  Lines        8931     8970      +39     
==========================================
+ Hits         6052     6091      +39     
  Misses       2879     2879
Impacted Files Coverage Δ
R/writeData.R 88.33% <ø> (ø)
R/WorkbookClass.R 60.53% <100.00%> (+0.09%) :arrow_up:
R/loadWorkbook.R 83.78% <100.00%> (+0.31%) :arrow_up:
R/setWindowSize.R 100.00% <100.00%> (ø)
R/workbook_write_data.R 92.99% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JanMarvin commented 1 year ago

Hi @michael-dewar , looking good. Just minor lintr issues and I'd like to see a test for this as well.

michael-dewar commented 1 year ago

I fixed the linter issues for the code I changed. I mostly avoided changing the other sections because I wasn't actually sure if the & vs && change made a difference compared to what was intended.

I also added tests.

JanMarvin commented 1 year ago

Thanks, the other changes should be in the development branch