search

ycphs / openxlsx

openxlsx - a fast way to read and write complex xslx files
https://ycphs.github.io/openxlsx/
Other
220 stars 74 forks source link

add C++11 as a req. to `DESCRIPTION` #398

Closed hutch3232 closed 1 year ago

hutch3232 commented 1 year ago

Fixes #396

(This is my first contribution to this project, I hope it is okay)

As the associated issue states, I'm unable to build this package as of tag 4.2.5 (but 4.2.4 works). Some digging makes me believe it was the new use of auto here: https://github.com/ycphs/openxlsx/compare/v4.2.4...v4.2.5#diff-b6d57bccb15a01d2c62f239b2a082c0df403ac0c6244c1d42282f9ca748d6a20R925

which requires C++11. I simply added it to the DESCRIPTION file and it successfully built from source.

Also tested on my Windows machine successfully.

# all passed
devtools::check()
hutch3232 commented 1 year ago

Hi @JanMarvin, I was wondering if you had any thoughts or feedback on this PR? I am experiencing the same issue with openxlsx2 but was waiting to post the same PR there until I gotten feedback on this one. Thanks for considering!

JanMarvin commented 1 year ago

@hutch3232 this is already in the latest CRAN release of openxlsx2 that's all I can say. Due to my own time restrictions I have moved on.

hutch3232 commented 1 year ago

My apologies, i didn't realize you recently added it to openxlsx2. Thank you!

On Wed, Jan 4, 2023, 1:31 PM Jan Marvin Garbuszus @.***> wrote:

@hutch3232 https://github.com/hutch3232 this is already in the latest CRAN release of openxlsx2 that's all I can say. Due to my own time restrictions I have moved on.

— Reply to this email directly, view it on GitHub https://github.com/ycphs/openxlsx/pull/398#issuecomment-1371334096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM3VB7YMAUKGNFDXBOJDM43WQXFYTANCNFSM6AAAAAASYZROWA . You are receiving this because you were mentioned.Message ID: @.***>