search

ycphs / openxlsx

openxlsx - a fast way to read and write complex xslx files
https://ycphs.github.io/openxlsx/
Other
220 stars 73 forks source link

Improve offline testing #433

Closed nanxstats closed 5 months ago

nanxstats commented 1 year ago

This pull request improves the handling of offline scenarios in tests that require an internet connection.

Specifically, it adds a skip_if_offline() call to these tests, which will prevent them from running when there is no internet connection detected.

This change improves the resilience of the unit tests and make it easier for people to run tests in different environments such as air gapped ones.

nanxstats commented 1 year ago

Hey @ycphs, could you take a quick look at this PR when you get a chance? I think it improves one aspect of the tests but not sure if there are other considerations when they were first written. Your feedback would be highly valuable. Thanks!