ycphs / openxlsx

openxlsx - a fast way to read and write complex xslx files
https://ycphs.github.io/openxlsx/
Other
226 stars 75 forks source link

Speed up row/column pair lookups #467

Closed StevenHibble-Concurrence closed 3 months ago

StevenHibble-Concurrence commented 6 months ago

Is your feature request related to a problem? Please describe. There are are few places in the codebase where row and column indices are combined with paste(). This is done in order to check a vector of pairs against another vector of pairs. For large datasets, this produces two large character vectors.

Describe the solution you'd like We could "hash" the combinations in some way (e.g. a simple pairing function would be ideal). Better yet would be a list-wise %in% operator, like the one the collapse package provides.