search

ycphs / openxlsx

openxlsx - a fast way to read and write complex xslx files
https://ycphs.github.io/openxlsx/
Other
220 stars 73 forks source link

Fix rdevel segfaults2 #473

Closed JanMarvin closed 1 month ago

JanMarvin commented 1 month ago

Hi @ycphs , your merge was a little to quick for me :)

I wanted to at least make the CI pass. There are a bunch of lintr and remaining other issues that I wont tackle. I was just curious to see if the segfault can be fixed and doing my part to keep the package on CRAN.

Fingers crossed that it will build now run without errors.

JanMarvin commented 1 month ago

Alright R-CMD-check run was a success! Adding curl as a dependency for three occurrences of a testthat function might be something to consider.

1) You might want to have a second look at my update of the github actions script in the previous commit. After a short night and a long day, I was losing it a bit and simply replaced everything with the current example (similar for this commit, but ...).

2) A long time ago, I started to merge a few commits into the development branch. Maybe if you go over the package the next time, you can resurrect a few.