"Generate Report Structure" progress bar doesn't track progress

ydataai / ydata-profiling

1 Line of code data quality profiling & exploratory data analysis for Pandas and Spark DataFrames.

https://docs.profiling.ydata.ai

MIT License

12.57k stars 1.69k forks source link

"Generate Report Structure" progress bar doesn't track progress #1336

Open gdevenyi opened 1 year ago

gdevenyi commented 1 year ago

Current Behaviour

The "Generate Report Structure" progress bar never moves. Other progress bars work.

I can see, since I'm running with html.inline = False that progress is happening as svg files are generated in the assets directly, however that progress is not tracked in the current bar.

Expected Behaviour

Progress bar should track the progress of generating the assets.

Data Description

N/A

Code that reproduces the bug

N/A

pandas-profiling version

v4.1.2

Dependencies

N/A

OS

No response

Checklist

[X] There is not yet another bug report for this issue in the issue tracker
[X] The problem is reproducible from this bug report. This guide can help to craft a minimal bug report.
[X] The issue has not been resolved by the entries listed under Common Issues.

fabclmnt commented 1 year ago

Hi @gdevenyi ,

thank you for opening this issue! May I ask to provide more details? On my side, it is not clear on what is the request from this issue. Perhaps a short video could help .

Thanks in advance for you help!

gdevenyi commented 1 year ago

Observe here, where "Generate report structure" remains at 0%, while I watch the assets get generated in the asset directory. The progress bar does not move at all until the whole procedure completes (several minutes later, not shown)

output.webm

fabclmnt commented 1 year ago

@gdevenyi this is due to the way Matplotlib works and how we can incorporate the visualizations into the html.

In fact, this is correct and expected, as the assets are calculated prior the generation of the html structure to accommodate the summary and visualizations.

gdevenyi commented 1 year ago

Looks to me like the pbar created at https://github.com/ydataai/ydata-profiling/blob/develop/src/ydata_profiling/report/structure/report.py#L363

Is wrapping a bunch of work that doesn't provide any feedback on update, and perhaps the sub functions should instead be instrumented with bars.

fabclmnt commented 1 year ago

Thank you for your feedback. We will considering adding more bars for sub functions in case this is a functionality requested for more member of the community!