search

ydataai / ydata-profiling

1 Line of code data quality profiling & exploratory data analysis for Pandas and Spark DataFrames.
https://docs.profiling.ydata.ai
MIT License
12.22k stars 1.65k forks source link

chore(deps): remove seaborn upper limit #1570

Closed ggydush closed 2 months ago

ggydush commented 2 months ago

Seaborn 0.13 fixes an issue with annotating heatmaps and I'd like to be able to use ydata-profiling in a repository that needs this fix.

I checked git blame and didn't see a reason for the upper-bound pin. I tested on 0.13.2 with Python 3.10 and all unit tests passed.

ggydush commented 2 months ago

Would you be okay with upper pin on latest (0.13.2) provided tests pass?

fabclmnt commented 2 months ago

Yes totally! That would do.

Tests are now running.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.19%. Comparing base (28ee3da) to head (15a8426).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1570 +/- ## ======================================== Coverage 90.19% 90.19% ======================================== Files 195 195 Lines 6394 6394 ======================================== Hits 5767 5767 Misses 627 627 ``` | [Flag](https://app.codecov.io/gh/ydataai/ydata-profiling/pull/1570/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydataai) | Coverage Δ | | |---|---|---| | [py3.8-ubuntu-22.04-pandas](https://app.codecov.io/gh/ydataai/ydata-profiling/pull/1570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydataai) | `90.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydataai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ggydush commented 2 months ago

Thank you for approving! Is there any chance this could be included in the next release?

alexbarros commented 2 months ago

@fabclmnt you can merge, the lint error is a problem in the actions itself, that is already fixed in dev

fabclmnt commented 2 months ago

@ggydush yes this will be included for the next release. Probably either this week or beginning of the next.

Thank you for your contribution.

ggydush commented 2 months ago

Any chance this could be released?