search

ydataai / ydata-profiling

1 Line of code data quality profiling & exploratory data analysis for Pandas and Spark DataFrames.
https://docs.profiling.ydata.ai
MIT License
12.56k stars 1.69k forks source link

docs: fix broken link for doc for great_expectations.md #1664

Open rugk opened 1 month ago

rugk commented 1 month ago

I know it's deprecated (which is also a little bit too subtle to be documented IMHO), but the link should work, at least.

rugk commented 3 weeks ago

Ah I thought the format you've followed was https://www.conventionalcommits.org/, which is why I instinctively used docs: (though it would also be hard to say whether this is a fix, yeah probably).

Unfortunately, that requirement is also not written on https://github.com/ydataai/ydata-profiling/blob/develop/CONTRIBUTING.md only can only see it when it's too late aka when a PR/commit is made… (in the CI or so)

Okay the CI still says:

Error: You have commit messages with errors

But not which one? And I see you used docs actually, so I was on the right track (for a different PR maybe, dunno what commit message I've used here), and the CI requires this(?), but it does not seem to work?

And thanks for fixing BTW, AFAIK you can also squash the commit when merging and get to enter a different commit message then.

rugk commented 3 weeks ago

Okay maybe it was the line length… anyway, it's a bit frustrating for me to guess what the CI actually wants from me… (Edit: ah and now the CI does not run because of that GitHub workflow approval ha, oh well… I hope it is fine for you now.)