search

ydb-platform / nbs

Network Block & File Store
Apache License 2.0
54 stars 21 forks source link

Fix wrong media kind usage #1465

Closed drbasic closed 3 months ago

drbasic commented 3 months ago

Тут мы можем получить nullptr в volumeInfo https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/client/session.cpp#L954 GetStorageMediaKind(nullptr) -> STORAGE_MEDIA_DEFAULT STORAGE_MEDIA_DEFAULT превращается в TotalHDD https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/diagnostics/request_stats.cpp#L498 и начинаем всю статистику ретраев валить в hdd

github-actions[bot] commented 3 months ago

[!NOTE] This is an automated comment that will be appended during run.

:green_circle: linux-x86_64-relwithdebinfo: all tests PASSED for commit 467d0676cc7aa098d5747cee4bb5c3d3c65c18b7. TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5287 5287 0 0 0 0
github-actions[bot] commented 3 months ago

[!NOTE] This is an automated comment that will be appended during run.

:green_circle: linux-x86_64-relwithdebinfo: all tests PASSED for commit 81e015b605a32fa3f4a7d2a8182cbbefe281f0de. TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5287 5284 0 0 1 2
github-actions[bot] commented 3 months ago

[!NOTE] This is an automated comment that will be appended during run.

:green_circle: linux-x86_64-relwithdebinfo: all tests PASSED for commit ea748fef63ecb4e4f88ec53239abbfea809f8a09. TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5288 5285 0 0 1 2