search

ydb-platform / nbs

Network Block & File Store
Apache License 2.0
58 stars 22 forks source link

[NBS] refactor checkpoint names #742

Open BarkovBG opened 8 months ago

BarkovBG commented 8 months ago

rename containers in TCheckpointStore to reasonable ones (checkpointsWithData/WithoutData, ...)

@leftmain has details

BarkovBG commented 8 months ago

https://github.com/ydb-platform/nbs/blob/201ea2a930c2435c6e6aeb87900382523d9f11c3/cloud/blockstore/libs/storage/partition/model/checkpoint.h#L69

qkrorlqr commented 8 months ago

@leftmain has details

эти детали должны быть в issue, иначе вообще непонятно, что тут хочется сделать и зачем

leftmain commented 8 months ago

There's a confusion for TCheckpointStore functions: Add, AddCheckpointMapping, Delete and DeleteCheckpointMapping.

For example Delete function actually performs the action "Delete checkpoint data" and you must call both Delete and DeleteCheckpointMapping to fully remove normal checkpoint.

On the other hand, Add function actually create full normal checkpoint and AddCheckpointMapping creates "checkpoint without data" (example).