Refactor and remove some redundant features - Githubissues

ydb-platform / xorm

Fork of https://gitea.com/xorm/xorm.git

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Refactor and remove some redundant features #26

Closed datbeohbbh closed 1 year ago

datbeohbbh commented 1 year ago

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number:

What is the new behavior?

Remove (*Engine) TransactionContext(...). Client can use (*Engine) SetDefaultContext(...) to modify the context, which will be used in transaction.
use errors.Is(err, driver.ErrSkip) in case ydb-go-sdk returns resultNoRows.
Other information