ydb-platform / ydb-embedded-ui

Apache License 2.0
28 stars 7 forks source link

improve detailed memory popup #1624

Open adameat opened 1 week ago

adameat commented 1 week ago

as a follow-up to recent introduction of detailed memory popup I suggest to do: 1. paint yellow when SharedCache and MemTable have reached 100% of their limit

  1. paint red when SharedCache and MemTable are over their limit more than 5%

...and be ready that consumption could be over limit.

image

kunga commented 1 week ago
  1. Show the whole bar status as: ~- warn if exceed soft limit + 5%~ ~- danger if exceed soft limit + 5% and exceed hard limit - 15%~
adameat commented 1 week ago
  • paint red when TotalUsage is over SoftLimit more than 5%

@kunga and what about yellow?

kunga commented 1 week ago

Theoretically it may be placed when we about to reach SoftLimit (and excess TargetUtilization)

Maybe somewhere in between (TargetUtilization + SoftLimit) / 2

adameat commented 1 week ago

Theoretically it may be placed when we about to reach SoftLimit (and excess TargetUtilization)

Maybe somewhere in between (TargetUtilization + SoftLimit) / 2

this is too complicated to implement on UI side. what is wrong with just SoftLimit alone? and where did you get 5% number from? I don't think it's a good idea to keep that logic on UI either.

kunga commented 1 week ago

5% is just a reasonable epsilon to compare numbers, you may pick whatever you want

or just draw it red when it exceed without a gap