ydb-platform / ydb-embedded-ui

MIT License
27 stars 7 forks source link

Request Hot Keys Sampling on empty response #624

Closed antonkovalenko closed 7 months ago

antonkovalenko commented 8 months ago

To draw HotKeys tab for a table viewer/json/hotkeys knob is requested. When response is empty, it must be called again with parameter enable_sampling=true.

Sampling will take aprox 5 seconds. Let's write a message `Please wait for 5 seconds while we looking for the hot keys"

After 5 seconds let's request viewer/json/hotkeys again.

If it's still empty let's write "No hot keys".

In autorefresh mode no enable_sampling=true parameter is required.

artemmufazalov commented 7 months ago

Currently, we have Hot Keys tab for column tables. However, it doesn't supported properly neither on frontend, nor on a backend.

I will disable this tab for column tables, if we want to add it later, we need to add support on backend.

Backend code: https://github.com/ydb-platform/ydb/blob/main/ydb/core/viewer/json_hotkeys.h#L84

artemmufazalov commented 7 months ago

I will disable this tab for column tables, if we want to add it later, we need to add support on backend

Update: data from column tables rarely requested by certain keys, more often it is range operations. So this tab is not really applicable there

antonkovalenko commented 7 months ago

Thanks

С уважением, Антон Коваленко тел: +7 926 214 77 82 telegram: kovalad@

On Wed, 14 Feb 2024 at 15:27, Артём Муфазалов @.***> wrote:

I will disable this tab for column tables, if we want to add it later, we need to add support on backend

Update: data from column tables rarely requested by certain keys, more often it is range operations. So this tab is not really applicable there

— Reply to this email directly, view it on GitHub https://github.com/ydb-platform/ydb-embedded-ui/issues/624#issuecomment-1943892061, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFJDKKIPY5CX5QQ3LR6D4DYTTCURAVCNFSM6AAAAABBR27AKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTHA4TEMBWGE . You are receiving this because you authored the thread.Message ID: @.***>