ydb-platform / ydb-embedded-ui

MIT License
27 stars 7 forks source link

Indentify replication targets tables with a sign #786

Closed antonkovalenko closed 2 months ago

antonkovalenko commented 5 months ago

Tables that receive changes from another database by means of async replicatoin are in read-only state.

Let's mark them with a special ring. It has to be an animated overlay on the standard table library

Image

And also let's display this info on Info panel and overpanel as well.

@CyberROFL knows parameter that is returned in describe for such tables

describe for a table that is a replicated targert must contain attribute __async_replica

CyberROFL commented 5 months ago

https://github.com/ydb-platform/ydb/issues/3317

artemmufazalov commented 3 months ago

Decided to mark tables with labels in Info instead of SchemaTree

Image

Raubzeug commented 2 months ago

@antonkovalenko @adameat Nonetheless, don't we want to show R/O label inside the schema tree? It's rather more clear as for me. And about icon. Animated part is not a good idea if speaking about performance. But what if we add a small lock? Something like

Screenshot 2024-07-03 at 09 45 34
artemmufazalov commented 2 months ago

@antonkovalenko @adameat Nonetheless, don't we want to show R/O label inside the schema tree? It's rather more clear as for me.

It's how our schema works. We cannot display R/O label without this object describe. So, to display labels in schema tree, we need either request data for all entities, which is rather uneffective, or we can display it only for opened entities, which is not very good as well.

Raubzeug commented 2 months ago

It's how our schema works. We cannot display R/O label without this object describe. So, to display labels in schema tree, we need either request data for all entities, which is rather uneffective, or we can display it only for opened entities, which is not very good as well.

I've totally missed this "small" thing :( And isn't it possible to return any additional field for children in describe?

adameat commented 2 months ago

I've totally missed this "small" thing :( And isn't it possible to return any additional field for children in describe?

it won't be cheap