ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB

https://ydb.tech

Apache License 2.0

133 stars 69 forks source link

Fixed goroutines leak #1228

Closed rekby closed 2 months ago

rekby commented 2 months ago

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Committer background worker started even topic reader doesn't started. And sometime it isn't stopped.

What is the new behavior?

Start committer only with start topic reader

github-actions[bot] commented 2 months ago

summary

Base version: v3.67.1-0.20240515164244-e409e01a17b7 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.67.0.

github-actions[bot] commented 2 months ago

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] commented 2 months ago

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] commented 2 months ago

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

github-actions[bot] commented 2 months ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table