search

ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
133 stars 69 forks source link

Enable funlen linter (part 7) #1252

Closed brojeg closed 1 month ago

brojeg commented 1 month ago

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: 934

What is the new behavior?

-

-

Other information

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 19.73684% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 40.82%. Comparing base (b7a9b51) to head (8749d66). Report is 226 commits behind head on master.

Files Patch % Lines
internal/xsql/conn.go 0.00% 57 Missing :warning:
...al/topic/topicwriterinternal/writer_reconnector.go 78.94% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1252 +/- ## ========================================== + Coverage 40.80% 40.82% +0.02% ========================================== Files 309 317 +8 Lines 32747 33568 +821 ========================================== + Hits 13361 13704 +343 - Misses 18959 19395 +436 - Partials 427 469 +42 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.86% <19.73%> (?)` | | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.92% <19.73%> (-0.01%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.75% <19.73%> (-0.04%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `?` | | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `?` | | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.82% <19.73%> (+0.02%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.82% <19.73%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.