ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
133 stars 69 forks source link

Enable funlen linter (part final) #1271

Closed brojeg closed 1 month ago

brojeg commented 1 month ago

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: 934

What is the new behavior?

-

-

Other information

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 42.86%. Comparing base (3536190) to head (90d1ab2). Report is 54 commits behind head on master.

:exclamation: Current head 90d1ab2 differs from pull request most recent head 36453bc

Please upload reports for the commit 36453bc to get more accurate results.

Files Patch % Lines
metrics/query.go 0.00% 139 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1271 +/- ## ========================================== + Coverage 40.88% 42.86% +1.98% ========================================== Files 317 261 -56 Lines 33570 24337 -9233 ========================================== - Hits 13724 10432 -3292 + Misses 19378 13468 -5910 + Partials 468 437 -31 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.85% <0.00%> (-0.07%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.84% <0.00%> (-0.09%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `?` | | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.86% <0.00%> (+2.42%)` | :arrow_up: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.83% <0.00%> (+2.39%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.86% <0.00%> (+1.98%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brojeg commented 1 month ago

funlen need to have more work