asmyasnikov commented 2 weeks ago

…ION_POOL for use internal/pool in query client + added SLO test for query client with pool

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (39d0d61) to head (a3aa767).

Files	Patch %	Lines
internal/query/session.go	77.77%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1306 +/- ## ========================================== - Coverage 41.36% 41.29% -0.07% ========================================== Files 321 321 Lines 33792 33782 -10 ========================================== - Hits 13977 13950 -27 - Misses 19346 19360 +14 - Partials 469 472 +3 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `43.50% <77.77%> (-0.06%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `43.49% <77.77%> (-0.07%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.25% <80.00%> (-0.08%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.84% <77.77%> (-0.06%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.81% <77.77%> (-0.07%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.29% <80.00%> (-0.07%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.24% <80.00%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

summary

Base version: v3.74.5-0.20240621173203-39d0d6197287 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.74.4.

github-actions[bot] commented 2 weeks ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table