search

ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
138 stars 73 forks source link

Add `query.ResultSet.Index()` method #1313

Closed neyguvj closed 3 months ago

neyguvj commented 3 months ago

Pull request type

Please check the type of change your PR introduces:

github-actions[bot] commented 3 months ago

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

ResultSet.Index: added

summary

Base version: v3.74.5 (master) Cannot suggest a release version. Incompatible changes were detected.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.28%. Comparing base (44ddaa6) to head (f2f56df).

Files Patch % Lines
internal/query/result_set.go 64.28% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1313 +/- ## ========================================== - Coverage 41.29% 41.28% -0.01% ========================================== Files 321 321 Lines 33782 33793 +11 ========================================== + Hits 13950 13953 +3 - Misses 19361 19370 +9 + Partials 471 470 -1 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `43.47% <70.58%> (-0.05%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `43.51% <70.58%> (-0.03%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.25% <70.58%> (-0.02%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.80% <73.33%> (-0.04%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.80% <73.33%> (-0.04%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.28% <70.58%> (-0.01%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.28% <70.58%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.