asmyasnikov commented 3 months ago

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

github-actions[bot] commented 3 months ago

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

Client.Stats: added Result.Stats: added

github.com/ydb-platform/ydb-go-sdk/v3/table/result

incompatible changes

BaseResult.Stats: changed from func() github.com/ydb-platform/ydb-go-sdk/v3/table/stats.QueryStats to func() github.com/ydb-platform/ydb-go-sdk/v3/internal/stats.QueryStats

github.com/ydb-platform/ydb-go-sdk/v3/table/stats

incompatible changes

CompilationStats: changed from CompilationStats to github.com/ydb-platform/ydb-go-sdk/v3/internal/stats.CompilationStats OperationStats: changed from OperationStats to github.com/ydb-platform/ydb-go-sdk/v3/internal/stats.OperationStats QueryPhase: changed from QueryPhase to github.com/ydb-platform/ydb-go-sdk/v3/internal/stats.QueryPhase QueryStats: changed from QueryStats to github.com/ydb-platform/ydb-go-sdk/v3/internal/stats.QueryStats TableAccess: changed from TableAccess to github.com/ydb-platform/ydb-go-sdk/v3/internal/stats.TableAccess

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

QueryOnResultNextPart: changed from func(Query, context.Context, call) func(error) to func(Query, context.Context, call) func(stats *github.com/ydb-platform/ydb-go-genproto/protos/YdbTableStats.QueryStats, error)

compatible changes

QueryResultNextPartDoneInfo.Stats: added

summary

Base version: v3.74.6-0.20240704085220-890206eacaa7 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.74.5.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.89888% with 17 lines in your changes missing coverage. Please review.

Project coverage is 41.87%. Comparing base (890206e) to head (9bc081a).

Files	Patch %	Lines
internal/stats/query.go	86.56%	6 Missing and 3 partials :warning:
internal/query/result.go	82.35%	2 Missing and 1 partial :warning:
internal/table/scanner/result.go	0.00%	3 Missing :warning:
log/query.go	0.00%	1 Missing :warning:
query/stats.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1317 +/- ## ========================================== + Coverage 41.73% 41.87% +0.13% ========================================== Files 321 321 Lines 34050 34055 +5 ========================================== + Hits 14211 14259 +48 + Misses 19371 19323 -48 - Partials 468 473 +5 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.19% <81.81%> (+0.14%)` | :arrow_up: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.18% <81.81%> (+0.12%)` | :arrow_up: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.83% <80.89%> (+0.13%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.36% <83.33%> (+0.16%)` | :arrow_up: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.38% <83.33%> (+0.14%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.87% <80.89%> (+0.13%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.84% <80.89%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table