asmyasnikov commented 4 days ago

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

github-actions[bot] commented 4 days ago

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

QueryOnPoolChange: changed from func(Query, int, int, int, int) to func(Query, int, int, int) QueryPoolChange.Index: removed

summary

Base version: v3.74.6-0.20240629083507-c2b8607a3fc0 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.74.5.

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 75.28090% with 22 lines in your changes missing coverage. Please review.

Project coverage is 41.22%. Comparing base (c2b8607) to head (d816c36).

Files	Patch %	Lines
internal/pool/pool.go	79.76%	12 Missing and 5 partials :warning:
internal/conn/grpc_client_stream.go	0.00%	4 Missing :warning:
internal/query/client.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1319 +/- ## ========================================== - Coverage 41.33% 41.22% -0.12% ========================================== Files 321 321 Lines 33793 33736 -57 ========================================== - Hits 13970 13907 -63 - Misses 19353 19358 +5 - Partials 470 471 +1 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `43.43% <75.28%> (-0.11%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `43.43% <75.28%> (-0.16%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.16% <75.28%> (-0.16%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.70% <73.97%> (-0.17%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `40.73% <73.97%> (-0.11%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.22% <75.28%> (-0.12%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.19% <75.28%> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query