search

ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

[OAuth 2 token exchange] Don't take lock when performing http request. Add retries #1323

Closed UgnineSirdis closed 1 month ago

UgnineSirdis commented 1 month ago

OAuth 2.0 token exchange credentials provider fixes and improvements

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.

Project coverage is 42.02%. Comparing base (491ebfa) to head (88a946e).

Files Patch % Lines
internal/credentials/oauth2.go 87.85% 11 Missing and 2 partials :warning:
credentials/options.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1323 +/- ## ========================================== + Coverage 41.95% 42.02% +0.07% ========================================== Files 321 321 Lines 34058 34130 +72 ========================================== + Hits 14288 14343 +55 - Misses 19300 19315 +15 - Partials 470 472 +2 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.32% <87.85%> (+0.03%)` | :arrow_up: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.32% <87.85%> (+0.03%)` | :arrow_up: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.99% <86.23%> (+0.05%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.47% <86.00%> (+0.02%)` | :arrow_up: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.50% <86.00%> (+0.03%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.02% <86.23%> (+0.07%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1323/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.00% <86.23%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.