search

ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

Fixed error more than one row if error raised on try read next row for query service #1327

Closed rekby closed 1 month ago

rekby commented 1 month ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

github-actions[bot] commented 1 month ago

summary

Base version: v3.75.0 (master) Suggested version: v3.75.1

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.19%. Comparing base (ac8cc8a) to head (34cab63).

Files Patch % Lines
internal/query/result.go 68.42% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1327 +/- ## ========================================== - Coverage 42.22% 42.19% -0.04% ========================================== Files 323 323 Lines 34299 34311 +12 ========================================== - Hits 14483 14476 -7 - Misses 19350 19366 +16 - Partials 466 469 +3 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.53% <68.42%> (-0.05%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.52% <68.42%> (-0.09%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.16% <68.42%> (-0.02%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.68% <68.42%> (-0.07%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.66% <68.42%> (-0.04%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.19% <68.42%> (-0.04%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.17% <68.42%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.