search

ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

Metrics over table #1328

Closed AlekseyGlushenok closed 1 month ago

AlekseyGlushenok commented 1 month ago

Add metrics:

table.session.query.latency
table.session.query.errs
table.session.query.attempts
table.session.tx.latency
table.session.tx.errs
table.session.tx.attempts

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: 1318

What is the new behavior?

Add metrics over table.Do and tabel.DoTx similar to query.Do and query.DoTx

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 41.96%. Comparing base (de97000) to head (1ffb2eb).

Files Patch % Lines
metrics/table.go 0.00% 31 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1328 +/- ## ========================================== - Coverage 42.05% 41.96% -0.10% ========================================== Files 321 321 Lines 34137 34168 +31 ========================================== - Hits 14357 14337 -20 - Misses 19310 19359 +49 - Partials 470 472 +2 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.28% <0.00%> (-0.10%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.29% <0.00%> (-0.13%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.91% <0.00%> (-0.08%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.49% <0.00%> (-0.05%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.49% <0.00%> (-0.05%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.96% <0.00%> (-0.10%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.94% <0.00%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.