ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

Added internal/xlist + switched internal/table.Client from container/list to internal/xlist #1329

Closed asmyasnikov closed 1 month ago

asmyasnikov commented 1 month ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

github-actions[bot] commented 1 month ago

summary

Base version: v3.74.6-0.20240709135459-2926c435487f (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.74.5.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.16%. Comparing base (2926c43) to head (06b7c55).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1329 +/- ## ========================================== + Coverage 42.01% 42.16% +0.15% ========================================== Files 321 322 +1 Lines 34168 34274 +106 ========================================== + Hits 14354 14451 +97 - Misses 19344 19355 +11 + Partials 470 468 -2 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.52% <100.00%> (+0.22%)` | :arrow_up: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.50% <100.00%> (+0.15%)` | :arrow_up: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.13% <100.00%> (+0.20%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.69% <100.00%> (+0.20%)` | :arrow_up: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.66% <100.00%> (+0.18%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.16% <100.00%> (+0.15%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.14% <100.00%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool