ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

refactoring of internal/pool #1337

Open asmyasnikov opened 1 month ago

asmyasnikov commented 1 month ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

github-actions[bot] commented 1 month ago

github.com/ydb-platform/ydb-go-sdk/v3/config

incompatible changes

(*Config).ConnectionTTL: removed

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

Client.Stats: changed from func() github.com/ydb-platform/ydb-go-sdk/v3/internal/pool/stats.Stats to func() github.com/ydb-platform/ydb-go-sdk/v3/internal/pool.Stats Stats: changed from func(Client) (github.com/ydb-platform/ydb-go-sdk/v3/internal/pool/stats.Stats, error) to func(Client) (github.com/ydb-platform/ydb-go-sdk/v3/internal/pool.Stats, error)

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

ConnState: removed DriverConnAllowDoneInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnAllowStartInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnBanDoneInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnBanStartInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnInvokeDoneInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnNewStreamDoneInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnStateChangeDoneInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverConnStateChangeStartInfo.State: changed from ConnState to google.golang.org/grpc/connectivity.State DriverOnConnAllow: changed from func(Driver, context.Context, call, EndpointInfo, ConnState) func(state ConnState) to func(Driver, context.Context, call, EndpointInfo, google.golang.org/grpc/connectivity.State) func(google.golang.org/grpc/connectivity.State) DriverOnConnBan: changed from func(Driver, context.Context, call, EndpointInfo, ConnState, error) func(state ConnState) to func(Driver, context.Context, call, EndpointInfo, google.golang.org/grpc/connectivity.State, error) func(google.golang.org/grpc/connectivity.State) DriverOnConnInvoke: changed from func(Driver, context.Context, call, EndpointInfo, Method) func( error, issues []Issue, opID string, state ConnState, metadata map[string][]string) to func(Driver, context.Context, call, EndpointInfo, Method) func( error, issues []Issue, opID string, google.golang.org/grpc/connectivity.State, metadata map[string][]string) DriverOnConnNewStream: changed from func(Driver, context.Context, call, EndpointInfo, Method) func( error, state ConnState) to func(Driver, context.Context, call, EndpointInfo, Method) func(error, google.golang.org/grpc/connectivity.State) DriverOnConnStateChange: changed from func(Driver, context.Context, call, EndpointInfo, ConnState) func(state ConnState) to func(Driver, context.Context, call, EndpointInfo, google.golang.org/grpc/connectivity.State) func(google.golang.org/grpc/connectivity.State) Query.OnPoolGet: removed Query.OnPoolPut: removed QueryOnPoolChange: changed from func(Query, int, int, int, int) to func(Query, int, int, int) QueryOnPoolGet: removed QueryOnPoolPut: removed QueryPoolChange.Index: removed QueryPoolGetDoneInfo: removed QueryPoolGetStartInfo: removed QueryPoolPutDoneInfo: removed QueryPoolPutStartInfo: removed

summary

Base version: v3.75.1-0.20240712184758-c83a350fb6b2 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.75.0.

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query