search

ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

moved internal/pool/stats.Stats to internal/pool.Stats #1338

Closed asmyasnikov closed 1 month ago

asmyasnikov commented 1 month ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

github-actions[bot] commented 1 month ago

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

Client.Stats: changed from func() github.com/ydb-platform/ydb-go-sdk/v3/internal/pool/stats.Stats to func() github.com/ydb-platform/ydb-go-sdk/v3/internal/pool.Stats Stats: changed from func(Client) (github.com/ydb-platform/ydb-go-sdk/v3/internal/pool/stats.Stats, error) to func(Client) (github.com/ydb-platform/ydb-go-sdk/v3/internal/pool.Stats, error)

summary

Base version: v3.75.1-0.20240715133542-43b57d6c1463 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.75.0.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.53%. Comparing base (43b57d6) to head (0d06f55).

Files Patch % Lines
internal/query/client.go 0.00% 8 Missing :warning:
internal/pool/pool.go 66.66% 1 Missing :warning:
query/stats.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1338 +/- ## ========================================== - Coverage 44.05% 42.53% -1.53% ========================================== Files 265 326 +61 Lines 24942 33646 +8704 ========================================== + Hits 10989 14311 +3322 - Misses 13512 18865 +5353 - Partials 441 470 +29 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.06% <18.18%> (+<0.01%)` | :arrow_up: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.64% <18.18%> (?)` | | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.69% <16.66%> (?)` | | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.70% <16.66%> (-2.36%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.71% <16.66%> (?)` | | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.53% <16.66%> (-1.53%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.58% <18.18%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.