asmyasnikov commented 1 month ago

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

github-actions[bot] commented 1 month ago

summary

Base version: v3.75.1-0.20240715133542-43b57d6c1463 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.75.0.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes missing coverage. Please review.

Project coverage is 42.17%. Comparing base (43b57d6) to head (8f56f1b). Report is 2 commits behind head on master.

Files	Patch %	Lines
driver.go	0.00%	24 Missing :warning:
internal/xsync/once.go	77.77%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1339 +/- ## ========================================== + Coverage 41.71% 42.17% +0.45% ========================================== Files 326 326 Lines 29079 34399 +5320 ========================================== + Hits 12131 14508 +2377 - Misses 16479 19420 +2941 - Partials 469 471 +2 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.61% <21.21%> (+0.55%)` | :arrow_up: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.05% <21.21%> (-0.01%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.15% <21.21%> (+0.47%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.70% <21.21%> (-0.02%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.71% <21.21%> (?)` | | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.17% <21.21%> (+0.45%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.15% <21.21%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table