ydb-platform / ydb-go-sdk

Pure Go native and database/sql driver for YDB
https://ydb.tech
Apache License 2.0
134 stars 70 forks source link

added internal/xerrors.WithNodeID(nodeID) option + removed internal/c… #1340

Closed asmyasnikov closed 1 month ago

asmyasnikov commented 1 month ago

…onn.connError

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

-

Other information

github-actions[bot] commented 1 month ago

github.com/ydb-platform/ydb-go-sdk/v3/retry

incompatible changes

retryableErrorOption: changed from func(github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors.retryableError) to interface{applyToRetryableError(re github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors.retryableError)}

summary

Base version: v3.75.1-0.20240715135426-7fabe9e78f43 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.75.0.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 35.00000% with 143 lines in your changes missing coverage. Please review.

Project coverage is 42.14%. Comparing base (7fabe9e) to head (36d76d0).

Files Patch % Lines
internal/conn/conn.go 35.71% 59 Missing and 4 partials :warning:
internal/conn/grpc_client_stream.go 0.00% 41 Missing :warning:
internal/xerrors/retryable.go 50.00% 16 Missing and 1 partial :warning:
internal/xerrors/transport.go 42.85% 7 Missing and 1 partial :warning:
internal/xerrors/operation.go 25.00% 5 Missing and 1 partial :warning:
internal/credentials/oauth2.go 73.68% 5 Missing :warning:
internal/xerrors/check.go 0.00% 2 Missing :warning:
internal/xerrors/issues.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1340 +/- ## ========================================== - Coverage 42.23% 42.14% -0.10% ========================================== Files 326 325 -1 Lines 34394 34415 +21 ========================================== - Hits 14527 14504 -23 - Misses 19400 19436 +36 - Partials 467 475 +8 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.59% <35.00%> (-0.08%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.59% <35.00%> (-0.10%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.10% <35.00%> (-0.08%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.67% <36.09%> (-0.07%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.67% <36.09%> (-0.10%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.14% <35.00%> (-0.10%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.12% <35.00%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query