asmyasnikov commented 1 month ago

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

github-actions[bot] commented 1 month ago

summary

Base version: v3.75.1-0.20240716120529-1b2f8d406425 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.75.0.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (d0ba2af) to head (32f0f7d).

Files	Patch %	Lines
internal/balancer/balancer.go	57.89%	8 Missing :warning:
internal/balancer/connections_state.go	44.44%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1344 +/- ## ========================================== - Coverage 42.29% 42.25% -0.04% ========================================== Files 329 329 Lines 34445 34426 -19 ========================================== - Hits 14567 14546 -21 - Misses 19401 19404 +3 + Partials 477 476 -1 ``` | [Flag](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | Coverage Δ | | |---|---|---| | [go-1.20.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.61% <53.57%> (-0.05%)` | :arrow_down: | | [go-1.21.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `44.60% <53.57%> (-0.07%)` | :arrow_down: | | [go-1.22.x](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.21% <53.57%> (-0.03%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.76% <53.84%> (-0.07%)` | :arrow_down: | | [ubuntu](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `41.79% <53.84%> (-0.02%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.25% <53.57%> (-0.04%)` | :arrow_down: | | [windows](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk/pull/1344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform) | `42.24% <53.57%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ydb-platform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table