ydb-platform / ydb-java-sdk

YDB Java SDK
https://ydb.tech
Apache License 2.0
37 stars 21 forks source link

Removing unused fields from ReaderSettings #337

Closed Myllyenko closed 1 week ago

Myllyenko commented 1 week ago

Removing unused fields to avoid misconfiguration of a reader.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.38%. Comparing base (959538e) to head (c0d89f5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #337 +/- ## ============================================ + Coverage 47.34% 47.38% +0.04% Complexity 1750 1750 ============================================ Files 309 309 Lines 12463 12448 -15 Branches 1232 1232 ============================================ - Hits 5901 5899 -2 + Misses 6102 6089 -13 Partials 460 460 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnv1 commented 1 week ago

Thank you for noticing! It's really better to just remove these options until they are used in any way