Closed Myllyenko closed 3 days ago
Attention: Patch coverage is 66.66667%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 47.21%. Comparing base (
9a7adfa
) to head (863193b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am not sure that we have to remove synchronized
from call classes. They are just simple wrappers on GrpcCall and all their calls are not blocking. In this case, synchronized
just adds thread safety to GrpcCall, especially with case data race on start() and cancel(). Replacing them by ReentrantLock makes them more complex and may reduce a performance
I am not sure that we have to remove
synchronized
from call classes. They are just simple wrappers on GrpcCall and all their calls are not blocking. In this case,synchronized
just adds thread safety to GrpcCall, especially with case data race on start() and cancel(). Replacing them by ReentrantLock makes them more complex and may reduce a performance
Reverted changes in StreamCall
s.
Continuation of https://github.com/ydb-platform/ydb-java-sdk/pull/338