ydb-platform / ydb

YDB is an open source Distributed SQL Database that combines high availability and scalability with strong consistency and ACID transactions
https://ydb.tech
Apache License 2.0
4.02k stars 582 forks source link

Improve compute nodes database error message #11750

Closed NeimadTL closed 2 days ago

NeimadTL commented 2 days ago

When the compute nodes try to start with a missing database and this error is thrown. However, in order to make it clearer for cluster administrators, the error message has been improved so that they know the reason why the error occurred.

Related issue: https://github.com/ydb-platform/ydb/issues/11057

github-actions[bot] commented 2 days ago

Hi! Thank you for contributing! The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

NeimadTL commented 2 days ago

Hi @pixcc, would appreciate your review on this, thank you.

github-actions[bot] commented 2 days ago

:white_circle: 2024-11-19 14:08:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3a063207630c2bb33dfed6a82f29d4c6248f77db has started. :white_circle: 2024-11-19 14:08:22 UTC Artifacts will be uploaded here :white_circle: 2024-11-19 14:11:21 UTC ya make is running... :black_circle: 2024-11-19 14:38:44 UTC Check cancelled

github-actions[bot] commented 2 days ago

:white_circle: 2024-11-19 14:08:11 UTC Pre-commit check linux-x86_64-release-asan for 3a063207630c2bb33dfed6a82f29d4c6248f77db has started. :white_circle: 2024-11-19 14:08:23 UTC Artifacts will be uploaded here :white_circle: 2024-11-19 14:11:22 UTC ya make is running... :black_circle: 2024-11-19 14:38:37 UTC Check cancelled

github-actions[bot] commented 2 days ago

:white_circle: 2024-11-19 14:43:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for f5cc34a8b41a1ab7386549d6c5c660b762133951 has started. :white_circle: 2024-11-19 14:43:40 UTC Artifacts will be uploaded here :white_circle: 2024-11-19 14:46:41 UTC ya make is running... :yellow_circle: 2024-11-19 15:35:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

[Test history](https://nebius.testmo.net/automation/runs/view/80126) | [Ya make output](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/ya_make_output.txt) | [Test bloat](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/try_1/test_bloat/tree_map.html) | TESTS | PASSED | ERRORS | FAILED | SKIPPED | MUTED[?](https://github.com/ydb-platform/ydb/tree/main/.github/config/muted_ya.txt "All mute rules are defined here") | | ---: | ---: | ---: | ---: | ---: | ---: | | [15436](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/try_1/ya-test.html) | [13917](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/try_1/ya-test.html#PASS) | 0 | [1](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/try_1/ya-test.html#FAIL) | [1406](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/try_1/ya-test.html#SKIP) | [112](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11915412939/ya-x86-64/try_1/ya-test.html#MUTE) |

:white_circle: 2024-11-19 15:36:35 UTC ya make is running... (failed tests rerun, try 2) :green_circle: 2024-11-19 15:47:56 UTC Tests successful.

Test history Ya make output Test bloat Test bloat TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 5 0 0 1 107
:green_circle: 2024-11-19 15:48:03 UTC Build successful. :green_circle: 2024-11-19 15:48:20 UTC ydbd size 2.5 GiB changed* by +192 Bytes, which is < 100.0 KiB vs main: OK ydbd size dash main: 92bb6c70bfe1c162c1d2e6ffe2170e0438834018 merge: f5cc34a8b41a1ab7386549d6c5c660b762133951 diff diff %
ydbd size 2 685 652 176 Bytes 2 685 652 368 Bytes +192 Bytes +0.000%
ydbd stripped size 481 259 120 Bytes 481 259 184 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

pixcc commented 2 days ago

@NeimadTL Thank you for your contribution. Let's wait for the CI checks, after which I'll merge the changes.

github-actions[bot] commented 2 days ago

:white_circle: 2024-11-19 14:45:48 UTC Pre-commit check linux-x86_64-release-asan for f5cc34a8b41a1ab7386549d6c5c660b762133951 has started. :white_circle: 2024-11-19 14:45:58 UTC Artifacts will be uploaded here :white_circle: 2024-11-19 14:48:57 UTC ya make is running... :yellow_circle: 2024-11-19 15:48:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history Ya make output Test bloat TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9019 8951 0 15 4 49
:green_circle: 2024-11-19 15:49:27 UTC Build successful. :green_circle: 2024-11-19 15:49:54 UTC ydbd size 4.9 GiB changed* by +400 Bytes, which is < 100.0 KiB vs main: OK ydbd size dash main: 92bb6c70bfe1c162c1d2e6ffe2170e0438834018 merge: f5cc34a8b41a1ab7386549d6c5c660b762133951 diff diff %
ydbd size 5 263 276 008 Bytes 5 263 276 408 Bytes +400 Bytes +0.000%
ydbd stripped size 1 351 579 696 Bytes 1 351 579 760 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

NeimadTL commented 2 days ago

@NeimadTL Thank you for your contribution. Let's wait for the CI checks, after which I'll merge the changes.

You're welcome, thanks for your review. Great !