ydb-platform / ydb

YDB is an open source Distributed SQL Database that combines high availability and scalability with strong consistency and ACID transactions
https://ydb.tech
Apache License 2.0
4.02k stars 581 forks source link

Fix LogPrefix initialization in Source/Sink/Transform/Channel helpers #11810

Open yumkam opened 1 day ago

yumkam commented 1 day ago

They are created in InitializeTask() (that is called from constructor), but LogPrefix assigned in CA::Bootstrap(). [v1] As all helper/info object are destroyed before CA, change their LogPrefix to reference into CA::LogPrefix [v2] Deemed fragile. Move LogPrefix assignment into InitializeTask instead. [v3][reverted, does not work] Move InitializeTask() into Bootstap() (SelfId only available after Bootstrap()) [v4] Return to v1 + WatermarkTracker fixes [v5] Rework to avoid fragile references

Changelog entry

...

Changelog category

Additional information

...

github-actions[bot] commented 1 day ago

:white_circle: 2024-11-20 15:56:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 31cadb498260310fb0eefe12818c26d1ec55851a has started. :white_circle: 2024-11-20 15:57:08 UTC Artifacts will be uploaded here :black_circle: 2024-11-20 16:00:07 UTC Check cancelled

github-actions[bot] commented 1 day ago

:white_circle: 2024-11-20 15:58:17 UTC Pre-commit check linux-x86_64-release-asan for 31cadb498260310fb0eefe12818c26d1ec55851a has started. :white_circle: 2024-11-20 15:58:28 UTC Artifacts will be uploaded here :black_circle: 2024-11-20 16:00:06 UTC Check cancelled

github-actions[bot] commented 1 day ago

:white_circle: 2024-11-20 16:01:39 UTC Pre-commit check linux-x86_64-release-asan for 2b25dc05a25be2e20284e16ca37b9cd7fd2ee1d4 has started. :white_circle: 2024-11-20 16:02:23 UTC Artifacts will be uploaded here :white_circle: 2024-11-20 16:05:31 UTC ya make is running... :yellow_circle: 2024-11-20 17:06:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history Ya make output Test bloat TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9237 9173 0 10 6 48
:green_circle: 2024-11-20 17:07:06 UTC Build successful. :green_circle: 2024-11-20 17:07:34 UTC ydbd size 4.9 GiB changed* by -22.4 KiB, which is <= 0 Bytes vs main: OK ydbd size dash main: dd01e456bccfc62249474d734efb54aeec53f28a merge: 2b25dc05a25be2e20284e16ca37b9cd7fd2ee1d4 diff diff %
ydbd size 5 266 044 608 Bytes 5 266 021 712 Bytes -22.4 KiB -0.000%
ydbd stripped size 1 351 951 824 Bytes 1 351 950 608 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] commented 1 day ago

:white_circle: 2024-11-20 16:04:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b25dc05a25be2e20284e16ca37b9cd7fd2ee1d4 has started. :white_circle: 2024-11-20 16:06:29 UTC Artifacts will be uploaded here :white_circle: 2024-11-20 16:09:43 UTC ya make is running... :black_circle: 2024-11-20 17:09:26 UTC Check cancelled

github-actions[bot] commented 1 day ago

:white_circle: 2024-11-20 17:11:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0988a3951625030f8e317ed4196797b653c8a5c has started. :white_circle: 2024-11-20 17:11:58 UTC Artifacts will be uploaded here :white_circle: 2024-11-20 17:15:32 UTC ya make is running... :yellow_circle: 2024-11-20 18:17:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

[Test history](https://nebius.testmo.net/automation/runs/view/80568) | [Ya make output](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/ya_make_output.txt) | [Test bloat](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/try_1/test_bloat/tree_map.html) | TESTS | PASSED | ERRORS | FAILED | SKIPPED | MUTED[?](https://github.com/ydb-platform/ydb/tree/main/.github/config/muted_ya.txt "All mute rules are defined here") | | ---: | ---: | ---: | ---: | ---: | ---: | | [73923](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/try_1/ya-test.html) | [59820](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/try_1/ya-test.html#PASS) | 0 | [6](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/try_1/ya-test.html#FAIL) | [13984](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/try_1/ya-test.html#SKIP) | [113](https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/11938313441/ya-x86-64/try_1/ya-test.html#MUTE) |

:white_circle: 2024-11-20 18:23:57 UTC ya make is running... (failed tests rerun, try 2) :green_circle: 2024-11-20 18:35:33 UTC Tests successful.

Test history Ya make output Test bloat Test bloat TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 9 0 0 1 107
:green_circle: 2024-11-20 18:35:40 UTC Build successful. :green_circle: 2024-11-20 18:35:56 UTC ydbd size 2.5 GiB changed* by -5.0 KiB, which is <= 0 Bytes vs main: OK ydbd size dash main: 872bb4d25b2454e82c5bbc045690c97cb64846ab merge: f0988a3951625030f8e317ed4196797b653c8a5c diff diff %
ydbd size 2 686 793 696 Bytes 2 686 788 608 Bytes -5.0 KiB -0.000%
ydbd stripped size 481 350 960 Bytes 481 350 640 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] commented 1 day ago

:white_circle: 2024-11-20 17:11:49 UTC Pre-commit check linux-x86_64-release-asan for f0988a3951625030f8e317ed4196797b653c8a5c has started. :white_circle: 2024-11-20 17:12:01 UTC Artifacts will be uploaded here :white_circle: 2024-11-20 17:15:18 UTC ya make is running... :yellow_circle: 2024-11-20 18:18:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history Ya make output Test bloat TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9238 9169 0 11 8 50
:green_circle: 2024-11-20 18:19:05 UTC Build successful. :green_circle: 2024-11-20 18:19:31 UTC ydbd size 4.9 GiB changed* by -7.1 KiB, which is <= 0 Bytes vs main: OK ydbd size dash main: dd01e456bccfc62249474d734efb54aeec53f28a merge: f0988a3951625030f8e317ed4196797b653c8a5c diff diff %
ydbd size 5 266 044 608 Bytes 5 266 037 360 Bytes -7.1 KiB -0.000%
ydbd stripped size 1 351 951 824 Bytes 1 351 947 472 Bytes -4.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] commented 20 hours ago

:white_circle: 2024-11-21 08:58:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab66089f604490eaf118eebb121baefb731da2b9 has started. :white_circle: 2024-11-21 08:58:24 UTC Artifacts will be uploaded here :black_circle: 2024-11-21 08:59:02 UTC Check cancelled

github-actions[bot] commented 20 hours ago

:white_circle: 2024-11-21 08:58:16 UTC Pre-commit check linux-x86_64-release-asan for ab66089f604490eaf118eebb121baefb731da2b9 has started. :white_circle: 2024-11-21 08:58:27 UTC Artifacts will be uploaded here :black_circle: 2024-11-21 08:59:02 UTC Check cancelled

github-actions[bot] commented 19 hours ago

:white_circle: 2024-11-21 09:00:58 UTC Pre-commit check linux-x86_64-release-asan for 8a34550f7903719acf10e9054d556e81b9496d30 has started. :white_circle: 2024-11-21 09:01:09 UTC Artifacts will be uploaded here :white_circle: 2024-11-21 09:04:05 UTC ya make is running... :black_circle: 2024-11-21 09:09:00 UTC Check cancelled

github-actions[bot] commented 19 hours ago

:white_circle: 2024-11-21 09:01:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a34550f7903719acf10e9054d556e81b9496d30 has started. :white_circle: 2024-11-21 09:01:15 UTC Artifacts will be uploaded here :white_circle: 2024-11-21 09:04:24 UTC ya make is running... :black_circle: 2024-11-21 09:09:00 UTC Check cancelled

github-actions[bot] commented 19 hours ago

:white_circle: 2024-11-21 09:11:23 UTC Pre-commit check linux-x86_64-release-asan for e921c8d662d07997151b0524fbb243baefe42d7d has started. :white_circle: 2024-11-21 09:11:34 UTC Artifacts will be uploaded here :white_circle: 2024-11-21 09:14:30 UTC ya make is running...

github-actions[bot] commented 19 hours ago

:white_circle: 2024-11-21 09:11:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for e921c8d662d07997151b0524fbb243baefe42d7d has started. :white_circle: 2024-11-21 09:11:52 UTC Artifacts will be uploaded here :white_circle: 2024-11-21 09:14:48 UTC ya make is running...

yumkam commented 17 hours ago

My personal preference: revert to v1 (as in here: https://github.com/yumkam/ydb/pull/new/fix-ca-source-sink-transform-logprefix-v1 ) and forget about the problem.

github-actions[bot] commented 11 hours ago

:white_circle: 2024-11-21 17:55:34 UTC Pre-commit check linux-x86_64-release-asan for b13d274bcc42fb935094e01cd5578c647c1cea71 has started. :white_circle: 2024-11-21 17:55:45 UTC Artifacts will be uploaded here :white_circle: 2024-11-21 17:58:41 UTC ya make is running... :red_circle: 2024-11-21 18:02:27 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] commented 11 hours ago

:white_circle: 2024-11-21 17:56:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for b13d274bcc42fb935094e01cd5578c647c1cea71 has started. :white_circle: 2024-11-21 17:56:57 UTC Artifacts will be uploaded here :white_circle: 2024-11-21 17:59:52 UTC ya make is running... :red_circle: 2024-11-21 18:04:02 UTC Build failed, see the logs. Also see fail summary