search

ydb-platform / ydb

YDB is an open source Distributed SQL Database that combines high availability and scalability with strong consistency and ACID transactions
https://ydb.tech
Apache License 2.0
3.98k stars 560 forks source link

zlib missing in contrib folder #51

Closed alexalanov closed 2 years ago

alexalanov commented 2 years ago

I tried to follow the build procedure at my ubuntu 20.04 workstation but build failed due to absence of contrib/libs/zlib/zlib.h which is referenced here

Obviously there's no zlib in contrib folder

ninja build output ``` [7980/12163] Building CXX object library/cpp/actors/http/CMakeFiles/cpp-actors-http.dir/http_compress.cpp.o FAILED: library/cpp/actors/http/CMakeFiles/cpp-actors-http.dir/http_compress.cpp.o /usr/bin/clang++-12 -DCARES_STATICLIB -DCATBOOST_OPENSOURCE=yes -I/data/ydbwork/ydb -I/data/ydbwork/build -I/data/ydbwork/ydb/contrib/libs/cxxsupp/libcxx/include -I/data/ydbwork/ydb/contrib/libs/double-conversion -I/data/ydbwork/ydb/contrib/libs/libc_compat/include/readpassphrase -I/data/ydbwork/ydb/contrib/libs/libc_compat/include/random -I/data/ydbwork/ydb/contrib/libs/protobuf/src -I/data/ydbwork/ydb/contrib/libs/brotli/include -I/data/ydbwork/ydb/contrib/libs/snappy/include -isystem /home/sasha/.conan/data/zlib/1.2.12/_/_/package/cf142e38e022cf2a99aadebfd8f37ead3e935ad7/include -isystem /home/sasha/.conan/data/openssl/1.1.1l/_/_/package/cf142e38e022cf2a99aadebfd8f37ead3e935ad7/include -isystem /home/sasha/.conan/data/libiconv/1.15/_/_/package/c4e0fbaccfc6985428b092ccc7aa4bcd74617546/include -isystem /home/sasha/.conan/data/c-ares/1.17.2/_/_/package/c2627225292f8d772a40f1bfef7180540cbf7f0d/include -m64 -fexceptions -fno-common -fuse-init-array -fcolor-diagnostics -faligned-allocation -ffunction-sections -fdata-sections -Wall -Wextra -Wno-parentheses -Wno-implicit-const-int-float-conversion -Wno-unknown-warning-option -D_THREAD_SAFE -D_PTHREADS -D_REENTRANT -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_YNDX_LIBUNWIND_ENABLE_EXCEPTION_BACKTRACE -D__LONG_LONG_SUPPORTED -DSSE_ENABLED=1 -DSSE3_ENABLED=1 -DSSSE3_ENABLED=1 -DSSE41_ENABLED=1 -DSSE42_ENABLED=1 -DPOPCNT_ENABLED=1 -DCX16_ENABLED=1 -D_libunwind_ -DLIBCXX_BUILDING_LIBCXXRT -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mpopcnt -mcx16 -Woverloaded-virtual -Wimport-preprocessor-directive-pedantic -Wno-undefined-var-template -Wno-return-std-move -Wno-address-of-packed-member -Wno-defaulted-function-deleted -Wno-pessimizing-move -Wno-range-loop-construct -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-enum-float-conversion -Wno-ambiguous-reversed-operator -Wno-deprecated-volatile -O3 -DNDEBUG -nostdinc++ -DLIBCXX_BUILDING_LIBCXXRT -D_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES -D_libunwind_ -std=c++20 -MD -MT library/cpp/actors/http/CMakeFiles/cpp-actors-http.dir/http_compress.cpp.o -MF library/cpp/actors/http/CMakeFiles/cpp-actors-http.dir/http_compress.cpp.o.d -o library/cpp/actors/http/CMakeFiles/cpp-actors-http.dir/http_compress.cpp.o -c /data/ydbwork/ydb/library/cpp/actors/http/http_compress.cpp /data/ydbwork/ydb/library/cpp/actors/http/http_compress.cpp:3:10: fatal error: 'contrib/libs/zlib/zlib.h' file not found #include ```
dcherednik commented 2 years ago

Include is incorrect. I am fixing it. Thank you.

dcherednik commented 2 years ago

Now it should be fixed. Try to pull last changes and build again.

alexalanov commented 2 years ago

Thanks, I updated source code and built it successfully.