search

ydb-platform / ydb

YDB is an open source Distributed SQL Database that combines high availability and scalability with strong consistency and ACID transactions
https://ydb.tech
Apache License 2.0
3.51k stars 493 forks source link

Adapt WideLastCombinerWrapper to work with spilling in LLVM #5416

Open Darych opened 3 weeks ago

Darych commented 3 weeks ago

Currently, spilling in WideLastCombiner works just when LLVM is disabled. It will be great to be able to use spilling in WideLastCombiner when LLVM is turned on.

Tony-Romanov commented 2 weeks ago

Get rid of using comp nodes inside state. https://github.com/Tony-Romanov/ydb/blob/main/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp#L352 Comp nodes must be used only directly from DoCalculate body.

Tony-Romanov commented 4 days ago

Another problem that I didn’t notice at first. Please return back members instead of this methods: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp#L415-L442

As here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp#L307-L308