search

yderidde / bindstyle-ember-helper

An ember.js extension to easily bind css style attributes
68 stars 15 forks source link

Added support for paths. #10

Closed gordonkristan closed 10 years ago

gordonkristan commented 11 years ago

I took code (almost verbatim) from the bindAttr helper in the Ember.js codebase. It has worked for me so far, but by no means have I done any extensive testing. If testing is required, I'm sure I'll have some time to write some test cases soon.

luxzeitlos commented 11 years ago

It also solves the Problem that bindStyle wasnt able to resolve item.foo inside an {{#each item in items}} helper.

yderidde commented 11 years ago

Cool I'll look into it and merge if i do not see regressions ! thanks

Emerson commented 10 years ago

Any reason this never got merged? Looking to use this as well.

yderidde commented 10 years ago

Sorry I got distracted. However this can't be merged automatically which means that there are merge conflicts. @gordonkristan Can you please make sure to issue a pull request from latest from master. Thanks very much :)

gordonkristan commented 10 years ago

I updated the pull request, so it should be able to be merged now.

yderidde commented 10 years ago

Thanks very much :)