Some small bug fixes and improvements

yderidde / bindstyle-ember-helper

An ember.js extension to easily bind css style attributes

68 stars 15 forks source link

Some small bug fixes and improvements #12

Closed nonsensery closed 6 years ago

nonsensery commented 10 years ago

First off, sorry that all three of these commits are in one pull request. I apparently do not understand GitHub yet.

(1) I noticed that the 'static' styles were being appended in each iteration of the loop, rather than once at the end. (2 + 3) Empty string and null values caused weird behavior.

yderidde commented 9 years ago

I just merged the changes for Ember 1.9, If you think some of your commits are still valuable please do a new pull request with those.

nonsensery commented 6 years ago

Woah, I had completely forgotten about this PR. Closing it, since it's massively out of date at this point.