QDYN release 2.1.2 - Githubissues

ydluo / qdyn

A Quasi-DYNamic earthquake simulator

59 stars 28 forks source link

QDYN release 2.1.2 #31

Closed martijnende closed 5 years ago

martijnende commented 5 years ago

Standard computed 2D kernels can now be exported using qdyn kernel, which writes the kernel "vectors" to files in the test/kernels/ directory. This includes any combination of finite/infinite/symmetric/asymmetric kernel geometries. These kernel files are used in the unit testing suite.
The unit testing suite has been expanded with kernel tests, comparing computed kernels with pre-computed ones stored in test/kernels/.
Re-computed the frozen benchmark for the Tse & Rice integration test based on version 2.1.0.

jpampuero commented 5 years ago

There is a circular dependency issue in this new version: modules fault_stress and problem_class depend on each other. This is not allowed in fortran. To fix it, instead of using pb as the new argument to various functions in fault_stress.f90, use just test_mode. In calls to init_kernel and export_kernel from outside the fault_stress module, use pb%test_mode as input.

martijnende commented 5 years ago

I noticed this indeed after updating my Makefile.depend. Curiously, it compiled and ran perfectly (passed tests) when Makefile.depend was not yet properly updated. I'll commit a fix soon.

martijnende commented 5 years ago

Since the next update will be more than incremental (documentation + Travis CI testing + kernel checks), I've decided to skip v2.1.1 and move straight to v2.2.0