search

ydns / bash-updater

YDNS Bash Updater Script
GNU General Public License v3.0
80 stars 43 forks source link

drop --sslv3 flag #42

Closed martinlindhe closed 8 years ago

martinlindhe commented 8 years ago

(which forced SSL v3), while https://ydns.io/ serves a TLS 1.2 cert, thus breaking the updater

Mikaela commented 8 years ago

Could you update the commit message or pull request and add "Closes #19" to the end so that issue gets closed when this is merged?

No one should support SSLv3 nowadays, because of POODLE and that probably happened with ydns and updater was forgotten.

commx commented 8 years ago

Thanks for the commit.

Seems like I forgot to modify this script to make sure that it still works, as we've explicitly blacklisted SSLv3 on server-side.

The --sslv3 was added some time ago [#10] by an contributor to ensure that we find a way to support SSL/TLS transport even for cURL versions which are quite old (those who may be older than 8-10+ years). By omitting the --sslv3 switch, cURL will automatically choose the best available protocol version.

Closes #19 too.

martinlindhe commented 8 years ago

Merge too? :)