search

yeKcim / my_nautilus_scripts

My Nautilus scripts
GNU General Public License v3.0
78 stars 11 forks source link

Subtitle download #7

Open kisst opened 6 years ago

kisst commented 6 years ago

Would you be interested to integrate this https://github.com/manojmj92/subtitle-downloader as well ?

yeKcim commented 6 years ago

Could be great but in my repository, one function = one file

kisst commented 6 years ago

Yeah a tidy up is needed for sure.

I'm just using your repo and did not wanted to fork just for this one function, but would not do the job of the refactoring if you will never merge.

But in that case I will tidy up the code into one file and send you a PR "soon".

Kabouik commented 6 years ago

Maybe this one would work then?

https://github.com/emericg/OpenSubtitlesDownload

It's a single file. I'm using it since several months, manually placed into ~./local/share/nautilus/scripts/videos, no particular issue.

kisst notifications@github.com wrote:

Yeah a tidy up is needed for sure.

I'm just using your repo and did not wanted to fork just for this one function, but would not do the job of the refactoring if you will never merge.

But in that case I will tidy up the code into one file and send you a PR "soon".

kisst commented 6 years ago

Whichever works I'm easy on it, the one thing is behind the first option is the support for different endpoints ( api.thesubdb.com, subscene.com ) but I guess opensubtitle can be good as well, plus the gui for the select and etc looks very good on the @Kabouik suggestion.

As it looks pretty advance already, and might be under active development... @yeKcim would you prefer a git submodule or copy over "clone" ?

kisst commented 6 years ago

@yeKcim ping