yeagerai / genlayer-js

MIT License
1 stars 1 forks source link

fix: allow accounts to be nullable in `readContract` and add `sim_getTransactionsForAddress` method #16

Closed AgustinRamiroDiaz closed 3 days ago

AgustinRamiroDiaz commented 1 month ago

What

Why

Testing done

Added unit tests

Decisions made

Checks

Reviewing tips

User facing release notes

AgustinRamiroDiaz commented 1 month ago

@cristiam86 @denishacquin do you know how to impose typescript checks in the tests? I'm being able to just test logic, but not typing

cristiam86 commented 1 month ago

@cristiam86 @denishacquin do you know how to impose typescript checks in the tests? I'm being able to just test logic, but not typing

I think that typing should be static, not tested. Do you have a concrete example?

AgustinRamiroDiaz commented 1 week ago

@cristiam86 I've managed to add tests to verify typing

AgustinRamiroDiaz commented 1 week ago

I've also fixed all eslint errors so test pass