yeagerai / genlayer-simulator

MIT License

16 stars 8 forks source link

feat: support both explicit and implicit vector ids in vector store #559

Closed denishacquin closed 1 month ago

denishacquin commented 1 month ago

Fixes #467

What

Allow explicitly setting vector IDs in the vector store while still supporting implicit / auto-incremental fallback.
- If no ID is provided, an new sequential ID will automatically be set.
- If ID already exists, an error is raised.

Why

to add more flexibility to the developers

Testing done

tested the different cases of explicit / implicit ID

Decisions made

Kept both explicit and implicit ID for flexibility

Checks

[x] I have tested this code
[x] I have reviewed my own PR
[x] I have created an issue for this PR
[x] I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Try it out with the log_indexer example contract

User facing release notes

Vector store now also supports passing explicit vector ID when adding new vectors

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.35%. Comparing base (2c0d2d9) to head (9105c36). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #559 +/- ## ======================================= Coverage 15.35% 15.35% ======================================= Files 112 112 Lines 7950 7950 Branches 187 187 ======================================= Hits 1221 1221 Misses 6653 6653 Partials 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

denishacquin commented 1 month ago

@AgustinRamiroDiaz I adapted for your comments - pinging your for a quick final check if you don't mind :)