yeagerai / genlayer-simulator

MIT License
16 stars 8 forks source link

feat: update transactions based on subscriptions events and remove polling #583

Closed denishacquin closed 1 week ago

denishacquin commented 2 weeks ago

Fixes #581

What

Why

Testing done

Checks

User facing release notes

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 80.99174% with 23 lines in your changes missing coverage. Please review.

Project coverage is 18.57%. Comparing base (cb516e4) to head (df37fdb). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/stores/transactions.ts 80.59% 12 Missing and 1 partial :warning:
frontend/src/stores/node.ts 16.66% 5 Missing :warning:
frontend/src/hooks/useSetupStores.ts 20.00% 4 Missing :warning:
frontend/src/main.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #583 +/- ## ========================================== + Coverage 17.78% 18.57% +0.79% ========================================== Files 122 122 Lines 9558 9586 +28 Branches 283 297 +14 ========================================== + Hits 1700 1781 +81 + Misses 7775 7722 -53 Partials 83 83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cristiam86 commented 2 weeks ago

Good job, do you think it would be possible to update the status in the transaction list panel at the bottom left while the events are received?

denishacquin commented 2 weeks ago

@cristiam86 I believe that's what's happening already, just it happens so fast you can only see the switch to finalized state.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

github-actions[bot] commented 1 week ago

:tada: This PR is included in version 0.20.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: